Ad generator hardcoded image instead of %asset$

Home Forums AdRotate for WordPress Bug Reports Ad generator hardcoded image instead of %asset$

This topic contains 4 replies, has 2 voices, and was last updated by  Arnan de Gans 1 week, 4 days ago.

  • #88376

    ourhometowninc
    Badges:

    Hello,

    In the recent update, the ads from the generator are putting out code with the hardcoded image srcset instead of the %asset% tag. Due to this, our customers are confused about why the images aren’t updating when they change the banner asset.

    This:
    <a href="https://google.com" target="_blank" rel="nofollow"><img src="%asset%" width="219" height="100" srcset="http://multisite.startup.our-hometown.com/wp-content/banners/dr-pepper-ad-e1556226934649.jpg 219w" sizes="1281px" /></a>

    Should be this:
    <a href="https://google.com" target="_blank" rel="nofollow"><img src="%asset%" width="219" height="100" srcset="%asset%" /></a>

    #88390

    Arnan de Gans
    Badges:

    But if the srcset uses the same asset as the main image the advert won’t work.
    As such, the generator, in its new(ish) form works as intended.

    There are code examples next to the AdCode field when you edit/create adverts which use the %asset% tag they can use.

    #88392

    ourhometowninc
    Badges:

    I see, is there any way you could add an option to not include the srcset in the generator when only using one image? Or have it so when the user changes the banner asset it updates the srcset?

    Right now, if you update the banner asset it doesn’t update the ad if it was generated.

    #88394

    Arnan de Gans
    Badges:

    That’s how it already works. If you skip the extra files there is no srcset attribute.
    And the primary image already uses %asset% at all times – I just checked.

    #88396

    Arnan de Gans
    Badges:

    Oh, it also adds the full size as the srcset. That’s not right. I’ll look into that.

Viewing 5 posts - 1 through 5 (of 5 total)

You must be logged in to reply to this topic.

You may be interested in