Even if the database is updated, the code is invalid for any MySQL database using specific strict modes which are now defaults for MySQL v8.
The issue is when you are using backticks for strings and they should be using single quotes.
Example:
$wpdb->query("UPDATE
{$wpdb->prefix}adrotate
SET
type
=
limit
WHERE
id
= {$banner->id};");
I submitted a lengthy bug report about this in March and now I do not see that report. Is it possible to find that report or was it deleted?
AdRotate doesn’t use backticks for strings. So that’s no problem.
I didn’t see a bug report from you. However, you can post it in the bug reports forum or send it via email.
– https://ajdg.solutions/forums/forum/adrotate-for-wordpress/bug-reports/
– https://ajdg.solutions/contact/
The code snippet I pasted is directly from your plugin, adrotate-functions.php line 206. The part that is type = limit uses backticks for both of those. The limit part should be enclosed in single quotes. There are multiple instances of this in that file as well.
I had to manually update the code to fix this but I can undo it to prove to you that the issue exists, just let me know.
Hmm, I see what you mean. You found a bug 😉
Your suggestion that this is a plugin wide problem is still not accurate though as that is not the norm in AdRotate (Pro).
Split and moved to bug reports.
I appreciate the acknowledgement on the bug. I must have failed at submitting the report in March before… who knows.
As for the other instances, I believe there are 5 total:
-
limit
– line 206 -
limit
– line 227 -
limit
– line 275 -
limit
– line 1071 -
budget
– line 281
Thanks!
I’ll have a look. Thanks!
I found one more actually 🙄
But it’ll be fixed for the next version.
Thanks Again.